Fix thread-safety issue in SingletonBase metaclass#85
Open
Omzee15 wants to merge 1 commit into52North:mainfrom
Open
Fix thread-safety issue in SingletonBase metaclass#85Omzee15 wants to merge 1 commit into52North:mainfrom
Omzee15 wants to merge 1 commit into52North:mainfrom
Conversation
- Added threading.Lock to prevent race conditions during instance creation - Implemented double-checked locking pattern for optimal performance - Updated docstring to reflect thread-safety guarantee - Removed TODO comment as the issue is now resolved This fix ensures that the singleton pattern works correctly in parallel execution contexts, preventing potential issues where multiple threads could create multiple instances simultaneously.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix ensures that the singleton pattern works correctly in parallel execution contexts, preventing potential issues where multiple threads could create multiple instances simultaneously.